-
Notifications
You must be signed in to change notification settings - Fork 104
Update npm package @types/nodemailer to v6.4.21
#7729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1062acb to
1314418
Compare
@types/nodemailer to v6.4.18@types/nodemailer to v6.4.19
1314418 to
4ca269b
Compare
4ca269b to
fdddf70
Compare
fdddf70 to
6ebae91
Compare
@types/nodemailer to v6.4.19@types/nodemailer to v6.4.20
apps/hash-api/package.json
Outdated
| "@types/md5": "2.3.5", | ||
| "@types/mime-types": "2.1.4", | ||
| "@types/nodemailer": "6.4.17", | ||
| "@types/nodemailer": "6.4.20", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pinned version 3.858.0 of @aws-sdk/client-ses conflicts with the newer version (3.901.0) required by the updated @types/[email protected], creating potential type mismatches and duplicate dependencies.
View Details
📝 Patch Details
diff --git a/apps/hash-api/package.json b/apps/hash-api/package.json
index b48c3c3b0..e3bc7eaa3 100644
--- a/apps/hash-api/package.json
+++ b/apps/hash-api/package.json
@@ -25,7 +25,7 @@
"dependencies": {
"@apps/hash-graph": "0.0.0-private",
"@aws-sdk/client-s3": "3.858.0",
- "@aws-sdk/client-ses": "3.858.0",
+ "@aws-sdk/client-ses": "^3.858.0",
"@aws-sdk/credential-provider-node": "3.858.0",
"@aws-sdk/s3-presigned-post": "3.858.0",
"@aws-sdk/s3-request-presigner": "3.858.0",
Analysis
Duplicate AWS SDK versions causing type mismatches and increased bundle size
What fails: Two versions of @aws-sdk/client-ses are installed: 3.858.0 (pinned) and 3.901.0 (from @types/[email protected]), causing TypeScript to potentially use different type definitions than runtime code in apps/hash-api/src/email/transporters/aws-ses-email-transporter.ts
How to reproduce:
# Check yarn.lock for duplicate entries:
grep -A2 '"@aws-sdk/client-ses@' yarn.lock
# Shows both 3.858.0 and 3.901.0 installed
# Verify @types/nodemailer dependency:
npm view @types/[email protected] dependencies
# Returns: { '@types/node': '*', '@aws-sdk/client-ses': '^3.731.1' }Result: Yarn installs both versions in the lockfile, increasing bundle size and creating potential for runtime/type inconsistencies where TypeScript may resolve to 3.901.0 types while runtime uses the 3.858.0 implementation
Expected: Single consistent version of @aws-sdk/client-ses used across all dependencies per npm deduplication best practices
6ebae91 to
953a8fa
Compare
Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/hashintel/hash/actions/runs/18323480961
953a8fa to
57b7966
Compare
Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/hashintel/hash/actions/runs/18688645946
57b7966 to
eef7dd3
Compare
@types/nodemailer to v6.4.20@types/nodemailer to v6.4.21
eef7dd3 to
00ccf0a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7729 +/- ##
==========================================
- Coverage 55.66% 55.66% -0.01%
==========================================
Files 1112 1112
Lines 101187 101195 +8
Branches 4684 4690 +6
==========================================
Hits 56329 56329
- Misses 44197 44205 +8
Partials 661 661
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR contains the following updates:
6.4.17->6.4.21Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - "before 4am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.