Skip to content

Conversation

@hash-worker
Copy link
Contributor

@hash-worker hash-worker bot commented Aug 16, 2025

This PR contains the following updates:

Package Change Age Confidence
@types/nodemailer (source) 6.4.17 -> 6.4.21 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - "before 4am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@hash-worker hash-worker bot enabled auto-merge August 16, 2025 18:49
hashdotai
hashdotai previously approved these changes Aug 16, 2025
@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) type/eng > backend Owned by the @backend team area/apps labels Aug 16, 2025
@hash-worker hash-worker bot force-pushed the deps/js/nodemailer-6.x branch from 1062acb to 1314418 Compare August 23, 2025 16:16
@hash-worker hash-worker bot changed the title Update npm package @types/nodemailer to v6.4.18 Update npm package @types/nodemailer to v6.4.19 Aug 23, 2025
hashdotai
hashdotai previously approved these changes Aug 23, 2025
hashdotai
hashdotai previously approved these changes Sep 1, 2025
hashdotai
hashdotai previously approved these changes Sep 20, 2025
@hash-worker hash-worker bot force-pushed the deps/js/nodemailer-6.x branch from fdddf70 to 6ebae91 Compare October 2, 2025 19:13
@hash-worker hash-worker bot changed the title Update npm package @types/nodemailer to v6.4.19 Update npm package @types/nodemailer to v6.4.20 Oct 2, 2025
hashdotai
hashdotai previously approved these changes Oct 2, 2025
"@types/md5": "2.3.5",
"@types/mime-types": "2.1.4",
"@types/nodemailer": "6.4.17",
"@types/nodemailer": "6.4.20",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pinned version 3.858.0 of @aws-sdk/client-ses conflicts with the newer version (3.901.0) required by the updated @types/[email protected], creating potential type mismatches and duplicate dependencies.

View Details
📝 Patch Details
diff --git a/apps/hash-api/package.json b/apps/hash-api/package.json
index b48c3c3b0..e3bc7eaa3 100644
--- a/apps/hash-api/package.json
+++ b/apps/hash-api/package.json
@@ -25,7 +25,7 @@
   "dependencies": {
     "@apps/hash-graph": "0.0.0-private",
     "@aws-sdk/client-s3": "3.858.0",
-    "@aws-sdk/client-ses": "3.858.0",
+    "@aws-sdk/client-ses": "^3.858.0",
     "@aws-sdk/credential-provider-node": "3.858.0",
     "@aws-sdk/s3-presigned-post": "3.858.0",
     "@aws-sdk/s3-request-presigner": "3.858.0",

Analysis

Duplicate AWS SDK versions causing type mismatches and increased bundle size

What fails: Two versions of @aws-sdk/client-ses are installed: 3.858.0 (pinned) and 3.901.0 (from @types/[email protected]), causing TypeScript to potentially use different type definitions than runtime code in apps/hash-api/src/email/transporters/aws-ses-email-transporter.ts

How to reproduce:

# Check yarn.lock for duplicate entries:
grep -A2 '"@aws-sdk/client-ses@' yarn.lock
# Shows both 3.858.0 and 3.901.0 installed

# Verify @types/nodemailer dependency:
npm view @types/[email protected] dependencies
# Returns: { '@types/node': '*', '@aws-sdk/client-ses': '^3.731.1' }

Result: Yarn installs both versions in the lockfile, increasing bundle size and creating potential for runtime/type inconsistencies where TypeScript may resolve to 3.901.0 types while runtime uses the 3.858.0 implementation

Expected: Single consistent version of @aws-sdk/client-ses used across all dependencies per npm deduplication best practices

@hash-worker hash-worker bot force-pushed the deps/js/nodemailer-6.x branch from 6ebae91 to 953a8fa Compare October 7, 2025 19:11
@github-actions github-actions bot dismissed hashdotai’s stale review October 7, 2025 19:11

Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/hashintel/hash/actions/runs/18323480961

hashdotai
hashdotai previously approved these changes Oct 7, 2025
@hash-worker hash-worker bot force-pushed the deps/js/nodemailer-6.x branch from 953a8fa to 57b7966 Compare October 21, 2025 15:13
@github-actions github-actions bot dismissed hashdotai’s stale review October 21, 2025 15:14

Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/hashintel/hash/actions/runs/18688645946

@hash-worker hash-worker bot force-pushed the deps/js/nodemailer-6.x branch from 57b7966 to eef7dd3 Compare October 27, 2025 04:49
@hash-worker hash-worker bot changed the title Update npm package @types/nodemailer to v6.4.20 Update npm package @types/nodemailer to v6.4.21 Oct 27, 2025
@hash-worker hash-worker bot force-pushed the deps/js/nodemailer-6.x branch from eef7dd3 to 00ccf0a Compare October 31, 2025 09:11
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.66%. Comparing base (7d08d9f) to head (00ccf0a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7729      +/-   ##
==========================================
- Coverage   55.66%   55.66%   -0.01%     
==========================================
  Files        1112     1112              
  Lines      101187   101195       +8     
  Branches     4684     4690       +6     
==========================================
  Hits        56329    56329              
- Misses      44197    44205       +8     
  Partials      661      661              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.32% <ø> (-0.01%) ⬇️
apps.hash-api 0.00% <ø> (ø)
local.hash-backend-utils 4.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps area/deps Relates to third-party dependencies (area) type/eng > backend Owned by the @backend team

Development

Successfully merging this pull request may close these issues.

3 participants